Skip to content

8381382: Shenandoah: assert(capacity > 0) failed: free regions must have allocation capacity#553

Closed
pengxiaolong wants to merge 1 commit into
openjdk:masterfrom
pengxiaolong:backport-pengxiaolong-01bfd427-master
Closed

8381382: Shenandoah: assert(capacity > 0) failed: free regions must have allocation capacity#553
pengxiaolong wants to merge 1 commit into
openjdk:masterfrom
pengxiaolong:backport-pengxiaolong-01bfd427-master

Conversation

@pengxiaolong

@pengxiaolong pengxiaolong commented May 8, 2026

Copy link
Copy Markdown

Hi all,

This pull request contains a backport of commit 01bfd427 from the openjdk/jdk repository.

The PR fix a memory order related bug that could corrupt heap, therefore I think it is necessary to backport it. It is not a clean backport because of renaming from Atomic to AtomicAccess in hotspot.

Test:

  • hotspot_gc_shenandoah

Thanks!



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8381382 needs maintainer approval

Issue

  • JDK-8381382: Shenandoah: assert(capacity > 0) failed: free regions must have allocation capacity (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/553/head:pull/553
$ git checkout pull/553

Update a local copy of the PR:
$ git checkout pull/553
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 553

View PR using the GUI difftool:
$ git pr show -t 553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/553.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented May 8, 2026

Copy link
Copy Markdown

👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented May 8, 2026

Copy link
Copy Markdown

@pengxiaolong This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381382: Shenandoah: assert(capacity > 0) failed: free regions must have allocation capacity

Reviewed-by: wkemper, kdnilsen, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport 01bfd427a322c6f92643c7920bbd1b1b35141a69 8381382: Shenandoah: assert(capacity > 0) failed: free regions must have allocation capacity May 8, 2026
@openjdk

openjdk Bot commented May 8, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added the backport Port of a pull request already in a different code base label May 8, 2026
@pengxiaolong pengxiaolong marked this pull request as ready for review May 8, 2026 19:29
@openjdk openjdk Bot added the rfr Pull request is ready for review label May 8, 2026
@mlbridge

mlbridge Bot commented May 8, 2026

Copy link
Copy Markdown

Webrevs

@earthling-amzn earthling-amzn left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdnilsen kdnilsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@earthling-amzn

Copy link
Copy Markdown

/approval request This change addresses a correctness issue introduced in https://bugs.openjdk.org/browse/JDK-8345423. Only Shenandoah is affected by the change.

@openjdk

openjdk Bot commented May 8, 2026

Copy link
Copy Markdown

@earthling-amzn Only the author (@pengxiaolong) is allowed to issue the /approval command.

@pengxiaolong

Copy link
Copy Markdown
Author

/approval request This change addresses a correctness issue introduced in https://bugs.openjdk.org/browse/JDK-8345423. Only Shenandoah is affected by the change.

@openjdk

openjdk Bot commented May 8, 2026

Copy link
Copy Markdown

@pengxiaolong
8381382: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label May 8, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels May 12, 2026
@pengxiaolong

Copy link
Copy Markdown
Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label May 12, 2026
@openjdk

openjdk Bot commented May 12, 2026

Copy link
Copy Markdown

@pengxiaolong
Your change (at version 6fdeb9f) is now ready to be sponsored by a Committer.

@earthling-amzn

Copy link
Copy Markdown

/sponsor

@openjdk

openjdk Bot commented May 12, 2026

Copy link
Copy Markdown

Going to push as commit d37b1cc.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label May 12, 2026
@openjdk openjdk Bot closed this May 12, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 12, 2026
@openjdk

openjdk Bot commented May 12, 2026

Copy link
Copy Markdown

@earthling-amzn @pengxiaolong Pushed as commit d37b1cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants